[postgis-tickets] [PostGIS] #4905: Revise shp2pgsql regress tests to include checking sql output

[PostGIS]

#4905: Revise shp2pgsql regress tests to include checking sql output
----------------------------+---------------------------
  Reporter:  robe           |      Owner:  stefanpetrea
      Type:  defect         |     Status:  new
  Priority:  low            |  Milestone:  PostGIS 3.2.0
 Component:  loader/dumper  |    Version:  master
Resolution:                 |   Keywords:
----------------------------+---------------------------

Comment (by stefanpetrea):

 Currently, the SQL output generated by shp2pgsql is generated
 [https://github.com/postgis/postgis/blob/82ab7bc5a31f68ab42acdec48f558aac3b855804/regress/run_test.pl#L942
 in a file] but it's overwritten every time a new loader test is run.

 In this pull request,
 [https://github.com/postgis/postgis/pull/611/commits/d1bd14c3bcc781af895b464e10b0350d478ef9c9
 #diff-0c9a2f7dbae71864e1d826c0dde26f8307227843b9413d0a8b08a9f41adc4b5bR973
 a check is now in place] if -Z was among the parameters passed to the
 loader, in which case, the generated SQL is checked for ANALYZE
 statements, and we expect there to be zero such statements there.

 Please review [https://github.com/postgis/postgis/pull/611 pull request
 611]

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4905#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.