[postgis-tickets] [PostGIS] #4905: Revise shp2pgsql regress tests to include checking sql output

PostGIS trac at osgeo.org
Wed May 5 14:23:31 PDT 2021


#4905: Revise shp2pgsql regress tests to include checking sql output
----------------------------+---------------------------
  Reporter:  robe           |      Owner:  stefanpetrea
      Type:  defect         |     Status:  new
  Priority:  low            |  Milestone:  PostGIS 3.2.0
 Component:  loader/dumper  |    Version:  master
Resolution:                 |   Keywords:
----------------------------+---------------------------

Comment (by stefanpetrea):

 Okay, I've discussed with strk. The approach in
 [https://github.com/postgis/postgis/pull/611 PR 611] is to test if the SQL
 generated by the loader contains ANALYZE statements. This was done by
 modifying the run_test.pl Perl script.

 There is another approach, which is to verify that no ANALYZE were run on
 the database by checking the system catalogs to see if the table
 statistics are up-to-date.
 I've discussed this with Sandro (@strk) and he likes this more than the
 previous approach.

 Please review [https://github.com/postgis/postgis/pull/612 PR 612].

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4905#comment:4>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-tickets mailing list