[postgis-tickets] [PostGIS] #5005: ST_FlatGeoBuf crashes with derived table

[PostGIS]

#5005: ST_FlatGeoBuf crashes with derived table
----------------------+---------------------------
 Reporter:  robe      |      Owner:  pramsey
     Type:  defect    |     Status:  new
 Priority:  critical  |  Milestone:  PostGIS 3.2.0
Component:  postgis   |    Version:  master
 Keywords:            |
----------------------+---------------------------
 {{{
 CREATE TABLE test AS
 SELECT x, y, ST_Point(x,y,4326)::geometry(POINT,4326) AS geom
 FROM generate_series(1,10,1) AS x,
  generate_series(10,1, -1) AS y;

 -- works
 SELECT ST_ASMVT(t)
 FROM (SELECT x, geom FROM test) AS t;

 -- crashes
 SELECT ST_ASFlatGeobuf(t)
 FROM (SELECT x, geom FROM test) AS t;
 }}}

 bt looks like


 {{{
 [Thread 1952.0x71f8 exited with code 0]

 Thread 1 received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 1952.0x4b50]
 pg_detoast_datum_copy (datum=0x1) at fmgr.c:1733
 1733            if (VARATT_IS_EXTENDED(datum))
 (gdb) bt
 #0  pg_detoast_datum_copy (datum=0x1) at fmgr.c:1733
 #1  0x00000000711c7568 in flatgeobuf_agg_transfn (ctx=ctx at entry=0x5341e00)
     at flatgeobuf.c:527
 #2  0x00000000711c7ed2 in pgis_asflatgeobuf_transfn (fcinfo=0x84d66c0)
     at lwgeom_out_flatgeobuf.c:74
 #3  0x0000000000607869 in ExecAggPlainTransByVal (setno=<optimized out>,
     aggcontext=<optimized out>, pergroup=0x5341bb8, pertrans=<optimized
 out>,
     aggstate=<optimized out>) at execExprInterp.c:4315
 #4  ExecInterpExpr (state=0x84d6470, econtext=0x5340468,
     isnull=<optimized out>) at execExprInterp.c:1713
 #5  0x0000000000623193 in ExecEvalExprSwitchContext (isNull=0x520f0af,
     econtext=<optimized out>, state=<optimized out>)
     at ../../../src/include/executor/executor.h:339
 #6  advance_aggregates (aggstate=0x5340030, aggstate=0x5340030)
     at nodeAgg.c:842
 #7  agg_retrieve_direct (aggstate=0x5340030) at nodeAgg.c:2454
 #8  ExecAgg (pstate=<optimized out>) at nodeAgg.c:2179
 #9  0x000000000060c88a in ExecProcNode (node=0x5340030)
     at ../../../src/include/executor/executor.h:257
 #10 ExecutePlan (execute_once=<optimized out>, dest=0x842f930,
     direction=<optimized out>, numberTuples=0, sendTuples=<optimized out>,
     operation=CMD_SELECT, use_parallel_mode=<optimized out>,
     planstate=0x5340030, estate=0x533fdf0) at execMain.c:1551
 #11 standard_ExecutorRun (queryDesc=0x8438f70, direction=<optimized out>,
     count=0, execute_once=<optimized out>) at execMain.c:361
 #12 0x00000000007c06eb in PortalRunSelect (portal=portal at entry=0x52dd0e0,
     forward=forward at entry=true, count=0, count at entry=2147483647,
     dest=dest at entry=0x842f930) at pquery.c:919
 #13 0x00000000007c244c in PortalRun (portal=portal at entry=0x52dd0e0,
     count=count at entry=2147483647, isTopLevel=isTopLevel at entry=true,
     run_once=run_once at entry=true, dest=dest at entry=0x842f930,
     altdest=altdest at entry=0x842f930, qc=qc at entry=0x520f360) at
 pquery.c:763
 #14 0x00000000007baacb in exec_simple_query (
     query_string=0x5314d30 "SELECT ST_ASFlatGeobuf(t)\nFROM (SELECT x,
 geom FROM test) AS t;") at postgres.c:1214
 #15 0x00000000007be40c in PostgresMain (argc=argc at entry=1,
     argv=argv at entry=0x520f980, dbname=<optimized out>,
     username=0x1f8e90 "postgres") at postgres.c:4486
 #16 0x00000000007202a1 in BackendRun (port=0x520f7b0, port=0x520f7b0)
     at postmaster.c:4506
 #17 SubPostmasterMain (argc=argc at entry=3, argv=argv at entry=0x1f6d80)
     at postmaster.c:5019
 #18 0x0000000000964b53 in main (argc=3, argv=0x1f6d80) at main.c:186

 }}}

 This is running with


 {{{
 PostgreSQL 14rc1 on x86_64-w64-mingw32, compiled by gcc.exe (x86_64-posix-
 seh-rev0, Built by MinGW-W64 project) 8.1.0, 64-bit

 POSTGIS="3.2.0dev 3.2.0alpha1-19-gf48c4a86a" [EXTENSION] PGSQL="140"
 GEOS="3.10.0dev-CAPI-1.15.0" SFCGAL="1.3.10" PROJ="7.1.1" GDAL="GDAL
 3.2.3, released 2021/04/27" LIBXML="2.9.9" LIBJSON="0.12"
 LIBPROTOBUF="1.2.1" WAGYU="0.5.0 (Internal)" TOPOLOGY RASTER
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5005>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.