[SCM] PostGIS branch stable-3.4 updated. 3.4.4-16-g122ad6f69

[git at osgeo.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "PostGIS".

The branch, stable-3.4 has been updated
       via  122ad6f692cdd6068b6fc8b2b9532a9204572fa0 (commit)
      from  6bc589417188b4480d8f84108a5514c923d6c131 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 122ad6f692cdd6068b6fc8b2b9532a9204572fa0
Author: Loïc Bartoletti <loic.bartoletti at oslandia.com>
Date:   Fri Apr 25 06:35:17 2025 +0200

    fix(CG_IsSolid): get SOLID flag
    
    The flag used was not the good one. GEODETIC instead of SOLID.

diff --git a/NEWS b/NEWS
index 530c179f1..d941d2939 100644
--- a/NEWS
+++ b/NEWS
@@ -11,7 +11,7 @@ Proj 6.1+ required.
   - #5876, Fix ST_AddPoint with empty point argument
   - #5874, Line substring returns wrong answer (Paul Ramsey)
   - #5829, geometry_columns with non-standard constraints (Paul Ramsey)
-
+  - #5818, GT-244 Fix CG_IsSolid function (Loïc Bartoletti)
 
 PostGIS 3.4.4
 2024/12/22
diff --git a/liblwgeom/lwgeom.c b/liblwgeom/lwgeom.c
index 6a1ec79cd..1dd07d5da 100644
--- a/liblwgeom/lwgeom.c
+++ b/liblwgeom/lwgeom.c
@@ -948,7 +948,7 @@ int
 lwgeom_is_solid(const LWGEOM *geom)
 {
 	if ( ! geom ) return LW_FALSE;
-	return FLAGS_GET_GEODETIC(geom->flags);
+	return FLAGS_GET_SOLID(geom->flags);
 }
 
 int
diff --git a/sfcgal/regress/regress_sfcgal.sql b/sfcgal/regress/regress_sfcgal.sql
index 17d6145a0..419b470c4 100644
--- a/sfcgal/regress/regress_sfcgal.sql
+++ b/sfcgal/regress/regress_sfcgal.sql
@@ -43,3 +43,18 @@ SELECT 'ST_3DUnion (aggregate)', ABS(ST_Volume(ST_3DUnion(g))) - 40 < 1e-12 FROM
     UNION
     SELECT ST_Extrude(ST_GeomFromText('POLYGON((-1 -1 -2, 1 -1 -2, 1 1 -2, -1 1 -2, -1 -1 -2))'), 0, 0, 4) AS g
 ) AS f;
+-- Test https://trac.osgeo.org/postgis/ticket/5818
+ WITH solid AS (
+     SELECT ST_MakeSolid(
+         'POLYHEDRALSURFACE Z (((-1 1 -1,1 1 -1,1 -1 -1,-1 -1 -1,-1 1 -1)),
+                               ((-1 1 1,-1 -1 1,1 -1 1,1 1 1,-1 1 1)),
+                               ((-1 1 -1,-1 1 1,1 1 1,1 1 -1,-1 1 -1)),
+                               ((1 1 -1,1 1 1,1 -1 1,1 -1 -1,1 1 -1)),
+                               ((1 -1 -1,1 -1 1,-1 -1 1,-1 -1 -1,1 -1 -1)),
+                               ((-1 -1 -1,-1 -1 1,-1 1 1,-1 1 -1,-1 -1 -1)))'
+     ) geom
+ )
+ SELECT
+     'ST_IsSolid',
+     ST_IsSolid(geom)
+ FROM solid;
diff --git a/sfcgal/regress/regress_sfcgal_expected b/sfcgal/regress/regress_sfcgal_expected
index 5dec99551..d29fdff01 100644
--- a/sfcgal/regress/regress_sfcgal_expected
+++ b/sfcgal/regress/regress_sfcgal_expected
@@ -14,3 +14,4 @@ postgis_sfcgal_noop|33
 ST_3DConvexHull|80.9227
 ST_3DUnion|t
 ST_3DUnion (aggregate)|t
+ST_IsSolid|t

-----------------------------------------------------------------------

Summary of changes:
 NEWS                                   |  2 +-
 liblwgeom/lwgeom.c                     |  2 +-
 sfcgal/regress/regress_sfcgal.sql      | 15 +++++++++++++++
 sfcgal/regress/regress_sfcgal_expected |  1 +
 4 files changed, 18 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
PostGIS