[SCM] PostGIS branch stable-3.3 updated. 3.3.7-27-g9bf3a56c3
git at osgeo.org
git at osgeo.org
Thu Apr 24 21:41:36 PDT 2025
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "PostGIS".
The branch, stable-3.3 has been updated
via 9bf3a56c38e33b907d687ed2eb415269be67e8ee (commit)
from b65e03b3034ddd6fc0dfad19468f208c61cdccf1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9bf3a56c38e33b907d687ed2eb415269be67e8ee
Author: Loïc Bartoletti <loic.bartoletti at oslandia.com>
Date: Fri Apr 25 06:35:17 2025 +0200
fix(CG_IsSolid): get SOLID flag
The flag used was not the good one. GEODETIC instead of SOLID.
diff --git a/NEWS b/NEWS
index 5649c66a4..c5d52b231 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ Proj 4.9+ required.
- #5876, Fix ST_AddPoint with empty point argument (Paul Ramsey)
- #5829, geometry_columns with non-standard constraints (Paul Ramsey)
+ - #5818, GT-244 Fix CG_IsSolid function (Loïc Bartoletti)
PostGIS 3.3.8
diff --git a/liblwgeom/lwgeom.c b/liblwgeom/lwgeom.c
index 4edf4d630..78e352225 100644
--- a/liblwgeom/lwgeom.c
+++ b/liblwgeom/lwgeom.c
@@ -948,7 +948,7 @@ int
lwgeom_is_solid(const LWGEOM *geom)
{
if ( ! geom ) return LW_FALSE;
- return FLAGS_GET_GEODETIC(geom->flags);
+ return FLAGS_GET_SOLID(geom->flags);
}
int
diff --git a/sfcgal/regress/regress_sfcgal.sql b/sfcgal/regress/regress_sfcgal.sql
index 17d6145a0..419b470c4 100644
--- a/sfcgal/regress/regress_sfcgal.sql
+++ b/sfcgal/regress/regress_sfcgal.sql
@@ -43,3 +43,18 @@ SELECT 'ST_3DUnion (aggregate)', ABS(ST_Volume(ST_3DUnion(g))) - 40 < 1e-12 FROM
UNION
SELECT ST_Extrude(ST_GeomFromText('POLYGON((-1 -1 -2, 1 -1 -2, 1 1 -2, -1 1 -2, -1 -1 -2))'), 0, 0, 4) AS g
) AS f;
+-- Test https://trac.osgeo.org/postgis/ticket/5818
+ WITH solid AS (
+ SELECT ST_MakeSolid(
+ 'POLYHEDRALSURFACE Z (((-1 1 -1,1 1 -1,1 -1 -1,-1 -1 -1,-1 1 -1)),
+ ((-1 1 1,-1 -1 1,1 -1 1,1 1 1,-1 1 1)),
+ ((-1 1 -1,-1 1 1,1 1 1,1 1 -1,-1 1 -1)),
+ ((1 1 -1,1 1 1,1 -1 1,1 -1 -1,1 1 -1)),
+ ((1 -1 -1,1 -1 1,-1 -1 1,-1 -1 -1,1 -1 -1)),
+ ((-1 -1 -1,-1 -1 1,-1 1 1,-1 1 -1,-1 -1 -1)))'
+ ) geom
+ )
+ SELECT
+ 'ST_IsSolid',
+ ST_IsSolid(geom)
+ FROM solid;
diff --git a/sfcgal/regress/regress_sfcgal_expected b/sfcgal/regress/regress_sfcgal_expected
index 5dec99551..d29fdff01 100644
--- a/sfcgal/regress/regress_sfcgal_expected
+++ b/sfcgal/regress/regress_sfcgal_expected
@@ -14,3 +14,4 @@ postgis_sfcgal_noop|33
ST_3DConvexHull|80.9227
ST_3DUnion|t
ST_3DUnion (aggregate)|t
+ST_IsSolid|t
-----------------------------------------------------------------------
Summary of changes:
NEWS | 1 +
liblwgeom/lwgeom.c | 2 +-
sfcgal/regress/regress_sfcgal.sql | 15 +++++++++++++++
sfcgal/regress/regress_sfcgal_expected | 1 +
4 files changed, 18 insertions(+), 1 deletion(-)
hooks/post-receive
--
PostGIS
More information about the postgis-tickets
mailing list