[QGIS-Developer] [Qgis-developer] Are there plans to create a unique "Add layer" tool?

Mon Jun 5 09:32:18 PDT 2017

Hi Alessandro

replies inline

Le lundi 5 juin 2017, Alessandro Pasotti <apasotti at gmail.com> a écrit :

> On Mon, Jun 5, 2017 at 1:54 PM, Stéphane Henriod <stephanebek at gmail.com
> <javascript:_e(%7B%7D,'cvml','stephanebek at gmail.com');>> wrote:
>
>> Hi Alessandro
>>
>> First of all, thank you so much for this work, it looks really great
>> already!
>>
>> Here a few comments / ideas after a few quick tests, I let you filter
>> which ones could actually be part of this phase and which ones should be
>> left out for a future phase 2
>>
>
> Hi,
>
> thanks for testing!
>

That's the least I can do when someone has already done the hard part, i.e.
developing :-)

>
>
>
>>
>> - "Raster" is not consistent: it is confusing that the file selector
>> opens directly. The behavior should mimick the "vector" (open the file
>> selector only when the user clicks on "browse")
>>
>
> yeah, I know,  this has been already discussed in the PR comments, please
> have a look.
>

Yes, I've seen that. But I was not sure  if a consensus has been reached.
Will it stay like this for now or is it still open for discussion? I would
favor the "extra-click" that would make it more consistent with the other
providers

>
>>
>> - The "DB2" logo should be cleaned (at least add transparency)
>>
>
>
> Sorry, I've no graphics design skills, and this task is really something
> that a not-programmer can contribute to. Changing the icons was not in
> scope btw.
>

I don't have such skills either but I'd be happy to try and at least make
the background transparent. I however don't know where to find the original
icon and how to push it back, once I have (maybe) successfully improved it.
(This had also been raised by Nyall)

>
>>
>> - When I click on "Browse", the file selector window opens behind the
>> Data Source Manager
>>
>
> Not sure I understand what you mean here, probably need more details, and
> it seems like a bug.
>

Here what I mean: https://vimeo.com/220330186

But it is not super consistent and doesn't necessarily happen everytime

I opened an issue here: https://issues.qgis.org/issues/16666

>
>
>>
>> - I would change the order of the providers: move the "Delimited text"
>> just below raster (so that we have all file-based providers together). And
>> maybe separate (visually) the providers in sections: "Files", "Databases",
>> "Web services", "Virtual" (or something like this). Also,"ArcGIS Feature
>> Server" should probably be just after "ArcGIS Map Server"
>>
>
>
> If I'm not mistaken, the order is  the same order we had before for the
> menu items and the icons, I did not alter the order (at least that was not
> my intention).
>

I indeed think that you kept the original order. But would it be out of the
scope of this first phase to clean up and make this order more intuitive?
It seems to me like a good opportunity but maybe I am underestimating the
associated workload?

>
>
>> - It would be super useful to be able to display a basemap (OSM, Google,
>> etc) directly from the Data Source Manager, without having to configure
>> "XYZ Tiles" in the browser.Would it be possible in this phase to add 1
>> entry in the Data source manager "Webmaps" where the user could simply pick
>> in a drop-down one of the most common webmaps (and could add additional XYZ
>> tiles)? This would be a golden feature for non-power users.
>>
>
>
> This is totally unrelated, but AFAIK there are plans to add some default
> xyz maps to the mix for 3.0.
>

Ok, thanks for the info!

>
>
>
>>
>> Thanks again, I will try to test it a bit deeper in the coming days
>>
>> Cheers
>> Stéphane
>>
>>
> Thanks again for the feed-back!
>
> Cheers.
>

You're very welcome!
Cheers

Stéphane

>
>
>
>>
>> Le lundi 5 juin 2017, Alessandro Pasotti <apasotti at gmail.com
>> <javascript:_e(%7B%7D,'cvml','apasotti at gmail.com');>> a écrit :
>>
>>> Hi Stéphane,
>>>
>>> Thanks for testing the new dialog!
>>>
>>> I think that if you find a bug (a crash or something that doesn't work
>>> as expected) you should open an issue on the hub and assign it to me.
>>>
>>> For general feed-back or change proposal for the UI/UX you can either
>>> use this thread or make a PR with the proposed changes and discuss them in
>>> the the PR.
>>>
>>> Cheers
>>>
>>>
>>> On Sun, Jun 4, 2017 at 8:14 PM, Stéphane Henriod <stephanebek at gmail.com>
>>> wrote:
>>>
>>>> Hi Alessandro
>>>>
>>>> I just downloaded the latest nightly build and will make some tests in
>>>> the coming days. What would be the most efficient / useful way to give you
>>>> feedback and comments? On this thread?
>>>>
>>>> Thanks and cheers
>>>>
>>>> Stéphane
>>>>
>>>>
>>>> Le jeudi 1 juin 2017, Alessandro Pasotti <apasotti at gmail.com> a écrit :
>>>>
>>>>> On Thu, Jun 1, 2017 at 11:22 AM, Stéphane Henriod <
>>>>> stephanebek at gmail.com> wrote:
>>>>>
>>>>>> I really look forward to testing it :-) Thanks a lot for our
>>>>>> involvement here!
>>>>>>
>>>>>>
>>>>>
>>>>> Thanks to Boundless for funding the development and thanks to all of
>>>>> you who participated with design, mockups, ideas, comments and reviews!
>>>>>
>>>>> This was a nice and effective cooperation.
>>>>>
>>>>>
>>>>> BTW, if you can't wait, a Docker with a nigthly build of the PR branch
>>>>> is available as "boundlessgeo/qgis-testing-environment:unified-button"
>>>>>
>>>>> Cheers
>>>>>
>>>>>
>>>>>>
>>>>>> Le mercredi 31 mai 2017, Alessandro Pasotti <apasotti at gmail.com> a
>>>>>> écrit :
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> final update: the development of what was in phase 1 is done.
>>>>>>>
>>>>>>> Actually, a bit more than phase 1 considering that we've redesigned
>>>>>>> the delimited text dialog GUI and I've done quite a bit of small
>>>>>>> refactorings of the providers selection dialogs interfaces.
>>>>>>>
>>>>>>> There has been a lot of feed-back, thank you all!
>>>>>>>
>>>>>>> As expected, there is no complete agreement over the final GUI bits
>>>>>>> for the menus and toolbars, and we still miss an icon (the green plus that
>>>>>>> I've used was only meant as a placeholder). I tried to keep the old toolbar
>>>>>>> available (disabled by default) mainly because it can spare a click and
>>>>>>> power users might want it back. Also, the new icon is the most prominent in
>>>>>>> the left bar and it's the first menu item in the layers menu.
>>>>>>>
>>>>>>> I have not a strong opinion about those toolbars and menus but I
>>>>>>> think I should wait no more and merge it as it is, then give the people
>>>>>>> some time to test the actual implementation and decide how to improve it.
>>>>>>>
>>>>>>> I kept the controversial part in a single commit so that it will be
>>>>>>> very easy to revert and propose a different placement for menus, icons and
>>>>>>> toolbars.
>>>>>>>
>>>>>>>
>>>>>>> Any objections if I proceed?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, May 24, 2017 at 2:29 PM, Alessandro Pasotti <
>>>>>>> apasotti at gmail.com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> a quick update:
>>>>>>>>
>>>>>>>> I've prepared a PR with a working prototype in
>>>>>>>> https://github.com/qgis/QGIS/pull/4629, I need some feed-back and
>>>>>>>> some help, expecially UX/UI about if we want it as a dockable dialog too
>>>>>>>> (and how to make it user-configurable).
>>>>>>>>
>>>>>>>> Feed-back welcome (but please keep it limited in scope to phase 1).
>>>>>>>>
>>>>>>>> Cheers
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, May 19, 2017 at 9:45 AM, Richard Duivenvoorde <
>>>>>>>> rdmailings at duif.net> wrote:
>>>>>>>>
>>>>>>>>> On 19-05-17 01:23, Nyall Dawson wrote:
>>>>>>>>>
>>>>>>>>> > On this note - I've recently discovered the need for some type of
>>>>>>>>> > reusable layer selection widget which allows choice of existing
>>>>>>>>> > layers/loading new layers from the file system/loading new
>>>>>>>>> layers from
>>>>>>>>> > available db/online connections. This would be extremely
>>>>>>>>> valuable for
>>>>>>>>> > processing too!
>>>>>>>>> >
>>>>>>>>> > So I'm really glad to hear that you'll be pushing ahead with
>>>>>>>>> this work
>>>>>>>>> > - thanks Boundless!
>>>>>>>>>
>>>>>>>>> Yep, and thanks Alessandro for the screenie. Makes me want more!
>>>>>>>>>
>>>>>>>>> @Nyall in Essen the talk was to start with what Alessandro wrote
>>>>>>>>> in his
>>>>>>>>> email, so 1 dialog 'merging' all buttons/widgets/dialogs into one,
>>>>>>>>> reuse
>>>>>>>>> as much as possible. So it was possible to get it into 3.0
>>>>>>>>>
>>>>>>>>> Off course people (.../me) started brainstorming about features
>>>>>>>>> which
>>>>>>>>> w/could be added too :-)
>>>>>>>>>
>>>>>>>>> Your idea adds (I think) to the idea to make some kind of
>>>>>>>>> 'datamanagement-console' in near future, where you can create/copy
>>>>>>>>> data(!), move data around (browser part) or delete it.
>>>>>>>>> Your note fits in this isn't it?
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Richard
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> QGIS-Developer mailing list
>>>>>>>>> QGIS-Developer at lists.osgeo.org
>>>>>>>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>>>>>>>> Unsubscribe: https://lists.osgeo.org/mailma
>>>>>>>>> n/listinfo/qgis-developer
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Alessandro Pasotti
>>>>>>>> w3:   www.itopen.it
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Alessandro Pasotti
>>>>>>> w3:   www.itopen.it
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> “When you travel, remember that a foreign country is not designed to
>>>>>> make you comfortable. It is designed to make its own people comfortable."
>>>>>> -- Clifton Fadiman
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Alessandro Pasotti
>>>>> w3:   www.itopen.it
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> “When you travel, remember that a foreign country is not designed to
>>>> make you comfortable. It is designed to make its own people comfortable."
>>>> -- Clifton Fadiman
>>>>
>>>>
>>>
>>>
>>> --
>>> Alessandro Pasotti
>>> w3:   www.itopen.it
>>>
>>
>>
>> --
>>
>> “When you travel, remember that a foreign country is not designed to make
>> you comfortable. It is designed to make its own people comfortable." --
>> Clifton Fadiman
>>
>>
>
>
> --
> Alessandro Pasotti
> w3:   www.itopen.it
>

-- 

“When you travel, remember that a foreign country is not designed to make
you comfortable. It is designed to make its own people comfortable." --
Clifton Fadiman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20170605/fec10d81/attachment-0001.html>