[QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18

[Alessandro Pasotti]

On Thu, Apr 12, 2018 at 10:56 AM, andreaerdna <andreaerdna at libero.it> wrote:

> Dear Alessandro,
> thanks for the tips.
>
> The strange thing is that my original pull request (#6524) passed all the
> tests so it would have been possible to merge it, but it was later closed
> by
> Nyall Dawson that slightly modified my commit and submitted a new pull
> request (#6620) that doesn't pass the tests.
>
> Do you think it would be appropriate to submit again the original pull
> request in order to circumvent this "impasse"?
>
> Best regards.
>
>
No: I think that what you need to do is to check the failure (which appears
to be a minor difference of 1 pixel in the size of the generate image) and
replace the reference image in order to make the test pass.


-- 
Alessandro Pasotti
w3:   www.itopen.it
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20180412/b429f347/attachment.html>