[QGIS-Developer] Can we remove a confirmation dialog in Refactor Fields algorithm?

[Arnaud Morvan]

Hello Germán

Note that I've already fixed some related problems with 
https://github.com/qgis/QGIS/pull/4964

Calling deleteLater should delete the dialog on next events processing.
Do dialog and child widgets signals should be correctly disconnected.

Arnaud


Le 25/04/2018 à 16:55, Germán Carrillo a écrit :
> Hi All,
>
>
> In the Refactor Fields algorithm dialog there is an "Input layer" 
> combo box. Each time the user selects one layer a modal dialog 
> (message box) appears, letting her select whether the fields mapping 
> should be reset or not. See image: [1].
>
>
> I'd like to ask you if we can get rid of such modal dialog for these 
> reasons:
>
>
> 1) In general, it's good to avoid modal dialogs as they block 
> workflows and hamper interaction.
>
> 2) Other algorithms don't use such dialog to warn users about 
> potential changes in other widgets (e.g., field combo boxes dependng 
> on the selected layer).
>
> 3) The dialog is only *useful* if the user clicks on the combo box by 
> accident and wants to avoid resetting the mapping (a very specific use 
> case). However, in that case the combo box shows that a new layer is 
> selected, but the mapping won't correspond to it, which is confusing.
>
> 4) Follow these steps:
>
>   a. Open QGIS and load a vector layer.
>   b. Open the Refactor Fields dialog and press ESC to close it.
>   c. Add another vector layer to QGIS.
>   d. Close the QGIS project.
>
> As soon as you close the project (e.g., when you want to start a new 
> one) the modal  dialog shows up :(  (see this short video [2]).
>
> 5) The dialog is triggered too many times when using the "Fields 
> Mapper" widget in a custom Processing model (and triggering it from a 
> plugin) (see this short video [3]).
>
>
>
> So, the question for you is: Can we get rid of it? I've created a PR 
> for that :D [4].
>
>
> Regards,
>
> Germán
> -----------
> [1] http://downloads.tuxfamily.org/tuxgis/tmp/ai/reset_field_mapping.png
> [2] 
> http://downloads.tuxfamily.org/tuxgis/tmp/ai/gif_refactor_fields_qgis.mp4
> [3] 
> http://downloads.tuxfamily.org/tuxgis/tmp/ai/gif_refactor_fields_plugin.mp4
> [4] https://github.com/qgis/QGIS/pull/6857
> -- 
> -----------
>    |\__
> (:>__)(
>    |/
> Soluciones Geoinformáticas Libres
> http://geotux.tuxfamily.org/
> http://twitter.com/GeoTux2
> http://about.me/germancarrillo
>
> <http://gis.stackexchange.com/users/4972/germ%c3%a1n-carrillo>
>
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20180426/8d4e4e15/attachment.html>