[QGIS-Developer] Rights to merge Pull Request even if CI is red
Julien Cabieces
julien.cabieces at oslandia.com
Thu Jun 25 05:59:53 PDT 2026
I would also be in favor on given up auto-merge to avoid blocking
approved pull requests with unrelated test failures.
At least, until we manage to strengthen our CI. I don't mind to ping you
or anyone else once in a while but I don't want to have to do it every
time. And at the moment the CI is very often broken.
Regards,
Julien
> Hi Nyall,
>
> your answer doesn't really answer my question :-) Is the restriction for every committer or a subset?
>
> Who has rights for changing qgis/qgis github settings? (not necessarily asking for them to be extended, but just so we know). It would be good
> to communicate when some settings that might affect workflows are adjusted
>
> I'd say that we should probably give up for now to auto-merge if it blocks approved pull requests from being merged
>
> Even
>
> Le 25/06/2026 à 13:30, Nyall Dawson a écrit :
>
> On Thu, 25 June 2026, 9:24 pm Even Rouault via QGIS-Developer, <qgis-developer at lists.osgeo.org> wrote:
>
> Hi Julien,
>
> I just tried looking at your PR [0] and I also don't seem to have the
> right to force merge it (only "auto-merge" rights that depend on green CI)
>
> It would be indeed great to have some clarification of who might have
> such rights or not, so we can see if there isn't a bottleneck that must
> be resolved. I'm not sure why we would want such rights to be restricted
> to a subset of people with "regular" merge rights rather than the whole
> group.
>
> An alternative would be to remove the merge rules which require tests to pass -- that'd avoid expanding rights while still allowing the
> blockage to be removed.
>
> (Downside is that doing this breaks the ability to "auto merge")
>
> Nyall
>
> Even
>
> Le 25/06/2026 à 12:24, Julien Cabieces via QGIS-Developer a écrit :
> > Hi devs,
> >
> > I cannot merge PR #66483 [0] because there is at least one unrelated
> > test failure every time the CI is launched (I restarted it 7 times), although the PR was approved
> > 6 days ago.
> >
> > I have already tackled the issue of the test_gui_fileuploader [1] which was
> > failing very often recently because of badssl.com being unstable but there
> > are now other issues.
> >
> > A few months ago, I had the rights to merge a PR even if tests were
> > failing, but I don't have them anymore and I cannot contribute anymore
> > on #66483 related issues (I have more fix commits based on this PR).
> >
> > It seems to me that other code committers still have these rights as I see
> > PRs with a red CI still being merged.
> >
> > May I have these rights too so I can continue to contribute normally?
> >
> > Shall every core committer have these rights ?
> >
> > Kind regards,
> > Julien
> >
> > [0] https://github.com/qgis/QGIS/pull/66483
> > [1] https://github.com/qgis/QGIS/pull/66543
> >
> --
> http://www.spatialys.com
> My software is free, but my time generally not.
> LLMs contribute to global warming and brain rot
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
--
Julien Cabieces
Senior Developer at Oslandia
julien.cabieces at oslandia.com
More information about the QGIS-Developer
mailing list