[postgis-tickets] [PostGIS] #3206: winnie crashing with topology ST_AddModeFace in C commit 9.3 w32 bit run
PostGIS
trac at osgeo.org
Sat Jul 18 21:31:31 PDT 2015
#3206: winnie crashing with topology ST_AddModeFace in C commit 9.3 w32 bit run
-----------------------+---------------------------
Reporter: robe | Owner: strk
Type: defect | Status: new
Priority: blocker | Milestone: PostGIS 2.2.0
Component: topology | Version: trunk
Resolution: | Keywords:
-----------------------+---------------------------
Comment (by robe):
okay I think we need to revert that change. It broke winnie's 64-bit in
addition to not fixing the 32-bit and seeing compile notices like this on
the 64-bit
{{{
/**********************************************************************
^
postgis_topology.c:26:0: warning: "POSTGIS_DEBUG_LEVEL" redefined [enabled
by default]
#define POSTGIS_DEBUG_LEVEL 1
^
In file included from postgis_topology.c:22:0:
../postgis_config.h:123:0: note: this is the location of the previous
definition
#define POSTGIS_DEBUG_LEVEL 0
^
postgis_topology.c: In function 'addEdgeValues':
postgis_topology.c:219:5: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
if ( edge->edge_id != -1 ) appendStringInfo(str, "%" PRId64,
edge->edge_id);
^
postgis_topology.c:224:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->start_node);
^
postgis_topology.c:228:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->end_node);
^
postgis_topology.c:232:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->face_left);
^
postgis_topology.c:236:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->face_right);
^
postgis_topology.c:240:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->next_left);
^
postgis_topology.c:241:5: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
if ( fullEdgeData ) appendStringInfo(str, ",%" PRId64,
ABS(edge->next_left));
^
postgis_topology.c:245:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, edge->next_right);
^
postgis_topology.c:246:5: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
if ( fullEdgeData ) appendStringInfo(str, ",%" PRId64,
ABS(edge->next_right));
^
postgis_topology.c: In function 'addEdgeUpdate':
postgis_topology.c:298:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->edge_id);
^
postgis_topology.c:303:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->start_node);
^
postgis_topology.c:308:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->end_node);
^
postgis_topology.c:313:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->face_left);
^
postgis_topology.c:318:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->face_right);
^
postgis_topology.c:323:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->next_left);
^
postgis_topology.c:327:7: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, ABS(edge->next_left));
^
postgis_topology.c:332:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, edge->next_right);
^
postgis_topology.c:336:7: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, ABS(edge->next_right));
^
postgis_topology.c: In function 'addNodeUpdate':
postgis_topology.c:377:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s %" PRId64, op, node->node_id);
^
postgis_topology.c:383:7: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%" PRId64, node->containing_face);
^
postgis_topology.c: In function 'addNodeValues':
postgis_topology.c:442:5: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
if ( node->node_id != -1 ) appendStringInfo(str, "%" PRId64,
node->node_id);
^
postgis_topology.c:449:7: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(str, "%s%" PRId64, sep, node->containing_face);
^
postgis_topology.c: In function 'addFaceValues':
postgis_topology.c:471:3: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
if ( face->face_id != -1 ) appendStringInfo(str, "(%" PRId64,
face->face_id);
^
postgis_topology.c: In function 'cb_getEdgeById':
postgis_topology.c:706:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_getEdgeByNode':
postgis_topology.c:752:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c:757:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_getEdgeByFace':
postgis_topology.c:805:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c:810:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_getFacesById':
postgis_topology.c:858:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_getRingEdges':
postgis_topology.c:911:5: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
edge, topo->name, ABS(edge), topo->name);
^
postgis_topology.c:911:5: warning: format '%d' expects argument of type
'int', but argument 5 has type 'LWT_ELEMID' [-Wformat=]
postgis_topology.c:952:5: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
POSTGIS_DEBUGF(1, "Component %d in ring of edge %" PRId64 " is edge
%d",
^
postgis_topology.c: In function 'cb_getNodeById':
postgis_topology.c:977:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_getNodeByFace':
postgis_topology.c:1022:5: warning: format '%d' expects argument of type
'int', but argument 4 has type 'LWT_ELEMID' [-Wformat=]
appendStringInfo(sql, "%s%" PRId64, (i?",":""), ids[i]);
^
postgis_topology.c: In function 'cb_updateFacesById':
postgis_topology.c:1526:7: warning: format '%d' expects argument of type
'int', but argument 3 has type 'LWT_ELEMID' [-Wformat=]
face->mbr->xmax, face->mbr->ymax, topo->srid);
^
postgis_topology.c: In function 'cb_updateTopoGeomEdgeSplit':
postgis_topology.c:1718:5: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topo->name, (new_edge2 == -1 ? "," : "USING" ), topo->id, split_edge
);
^
postgis_topology.c:1779:7: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topogeo_id, layer_id, negate ? -new_edge1 : new_edge1,
element_type);
^
postgis_topology.c:1792:9: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topogeo_id, layer_id, negate ? -new_edge2 : new_edge2,
element_type);
^
postgis_topology.c: In function 'cb_updateTopoGeomFaceSplit':
postgis_topology.c:1818:3: warning: format '%d' expects argument of type
'int', but argument 5 has type 'LWT_ELEMID' [-Wformat=]
POSTGIS_DEBUGF(1, "cb_updateTopoGeomFaceSplit signalled "
^
postgis_topology.c:1818:3: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
postgis_topology.c:1818:3: warning: format '%d' expects argument of type
'int', but argument 7 has type 'LWT_ELEMID' [-Wformat=]
postgis_topology.c:1832:5: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topo->name, (new_face2 == -1 ? "," : "USING" ), topo->id, split_face
);
^
postgis_topology.c:1895:7: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topogeo_id, layer_id, negate ? -new_face1 : new_face1,
element_type);
^
postgis_topology.c:1911:9: warning: format '%d' expects argument of type
'int', but argument 6 has type 'LWT_ELEMID' [-Wformat=]
topogeo_id, layer_id, negate ? -new_face2 : new_face2,
element_type);
^
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-
statement -Wendif-labels -Wmissing-format-attribute -Wformat-security
-fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -shared
-static-libgcc -o postgis_topology-2.2.dll postgis_topology.o
-Le:/jenkins/postgresql/rel/pg9.4w64gcc48/lib -Wl,--allow-multiple-
definition -Wl,--disable-auto-import -L/projects/libxml/rel-
libxml2-2.7.8w64gcc48/lib -Wl,--as-needed ../libpgcommon/libpgcommon.a
../liblwgeom/.libs/liblwgeom.a -L/projects/geos/rel-3.5.0devw64gcc48/lib
-L/projects/proj/rel-4.9.1w64gcc48/lib -lgeos_c -lproj
-L/projects/json-c/rel-0.12w64gcc48/lib -ljson-c -L/projects/libxml/rel-
libxml2-2.7.8w64gcc48/lib -lxml2 -lws2_32 -L/projects/CGAL/rel-
sfcgal-1.1.0w64gcc48/lib -lSFCGAL -L/projects/pcre/rel-8.33w64gcc48/lib
-L/projects/CGAL/rel-sfcgal-1.1.0w64gcc48/lib -lSFCGAL
-Le:/jenkins/postgresql/rel/pg9.4w64gcc48/lib -lpostgres -lpgcommon
-lpgport -lxml2 -lwsock32 -lm -lws2_32 -Wl,--export-all-symbols -Wl
,--out-implib=libpostgis_topology-2.2.a
/mingw/bin/cpp -traditional-cpp -w -P topology.sql.in | grep -v '^#' | \
/bin/perl -lpe "s'MODULE_PATHNAME'\$libdir/postgis_topology-2.2'g" >
topology.sql
/mingw/bin/cpp -traditional-cpp -w -P topology_drop_before.sql.in | grep
-v '^#' | \
/bin/perl -lpe "s'MODULE_PATHNAME'\$libdir/postgis_topology-2.2'g" >
topology_drop_before.sql
/bin/perl -0777 -ne 's/^(CREATE|ALTER)
(CAST|OPERATOR|TYPE|TABLE|SCHEMA|DOMAIN|TRIGGER).*?;//msg;print;'
topology.sql > topology_upgrade.sql.in
/mingw/bin/cpp -traditional-cpp -w -P topology_drop_after.sql.in | grep -v
'^#' | \
/bin/perl -lpe "s'MODULE_PATHNAME'\$libdir/postgis_topology-2.2'g" >
topology_drop_after.sql
cat topology_drop_before.sql topology_upgrade.sql.in
topology_drop_after.sql > topology_upgrade.sql
/bin/perl ../utils/create_undef.pl topology.sql 94 >
uninstall_topology.sql
make[1]: Leaving directory `/projects/postgis/branches/2.2/topology'
---- Making all in loader
make[1]: Entering directory `/projects/postgis/branches/2.2/loader'
x86_64-w64-mingw32-gcc -I ../liblwgeom -g -O2 -DDLL_EXPORT -DPIC -Wall
-Wmissing-prototypes -I/projects/proj/rel-4.9.1w64gcc48/include
-I/projects/rel-libiconv-1.13.1w64gcc48/include -I. -I./
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/internal
-I./src/include/port/win32 -DEXEC_BACKEND -I/projects/libxml/rel-
libxml2-2.7.8w64gcc48/include/libxml2 "-I/src/include/port/win32"
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server/port/win32 -c -o
shpopen.o shpopen.c
x86_64-w64-mingw32-gcc -I ../liblwgeom -g -O2 -DDLL_EXPORT -DPIC -Wall
-Wmissing-prototypes -I/projects/proj/rel-4.9.1w64gcc48/include
-I/projects/rel-libiconv-1.13.1w64gcc48/include -I. -I./
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/internal
-I./src/include/port/win32 -DEXEC_BACKEND -I/projects/libxml/rel-
libxml2-2.7.8w64gcc48/include/libxml2 "-I/src/include/port/win32"
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server/port/win32 -c -o
dbfopen.o dbfopen.c
x86_64-w64-mingw32-gcc -I ../liblwgeom -g -O2 -DDLL_EXPORT -DPIC -Wall
-Wmissing-prototypes -I/projects/proj/rel-4.9.1w64gcc48/include
-I/projects/rel-libiconv-1.13.1w64gcc48/include -I. -I./
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/internal
-I./src/include/port/win32 -DEXEC_BACKEND -I/projects/libxml/rel-
libxml2-2.7.8w64gcc48/include/libxml2 "-I/src/include/port/win32"
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server/port/win32 -c -o
getopt.o getopt.c
x86_64-w64-mingw32-gcc -I ../liblwgeom -g -O2 -DDLL_EXPORT -DPIC -Wall
-Wmissing-prototypes -I/projects/proj/rel-4.9.1w64gcc48/include
-I/projects/rel-libiconv-1.13.1w64gcc48/include -I. -I./
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/internal
-I./src/include/port/win32 -DEXEC_BACKEND -I/projects/libxml/rel-
libxml2-2.7.8w64gcc48/include/libxml2 "-I/src/include/port/win32"
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server/port/win32 -c -o
shpcommon.o shpcommon.c
x86_64-w64-mingw32-gcc -I ../liblwgeom -g -O2 -DDLL_EXPORT -DPIC -Wall
-Wmissing-prototypes -I/projects/proj/rel-4.9.1w64gcc48/include
-I/projects/rel-libiconv-1.13.1w64gcc48/include -I. -I./
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/internal
-I./src/include/port/win32 -DEXEC_BACKEND -I/projects/libxml/rel-
libxml2-2.7.8w64gcc48/include/libxml2 "-I/src/include/port/win32"
-Ie:/jenkins/postgresql/rel/pg9.4w64gcc48/include/server/port/win32 -c -o
safileio.o safileio.c
safileio.c:74:0: warning: ignoring #pragma comment [-Wunknown-pragmas]
# pragma comment(lib, "kernel32.lib")
^
safileio.c:219:16: warning: no previous prototype for 'Utf8ToWideChar'
[-Wmissing-prototypes]
const wchar_t* Utf8ToWideChar( const char *pszFilename )
^
safileio.c:247:8: warning: no previous prototype for 'SAUtf8WFOpen'
[-Wmissing-prototypes]
SAFile SAUtf8WFOpen( const char *pszFilename, const char *pszAccess )
^
safileio.c:266:5: warning: no previous prototype for 'SAUtf8WRemove'
[-Wmissing-prototypes]
int SAUtf8WRemove( const char *pszFilename )
}}}
--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3206#comment:8>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list